Should I merge it now? Yes.
I found no blocking defect introduced by this PR.
The role check fixes the incorrect payment flag at its source. The checkout fallback also handles a successful redemption request that reports nothing to redeem. It shows the existing thank-you modal after the payment has already succeeded.
TypeScript and Angular template compilation pass. The main application builds with the development configuration. All 33 targeted checks pass, and the base commit reproduces the old failures.
GitHub confirms that PR 10910 merged on 7 October 2026 at 17:37 IST, while I prepared this document. The reviewed head is unchanged. The merge commit is a0eb0d35ec. The reviewed head has no listed check runs, commit statuses, or submitted reviews. That is an absence of CI evidence, not a green CI result.
What changes
Only the creator replying to a fan can fulfill a pending guarantee
The new shouldFulfillGuaranteedReply helper requires a creator sender, a pending guaranteed reply, and a recipient who is not a creator. The upload flow and send dispatcher use that same check. The three payment payload builders also check it before setting fulfillGuaranteedReply.
A normal fan tip, a paid message, and a message with a tip now carry fulfillGuaranteedReply: false, even when an old pending flag is present. A fan buying a guaranteed reply still keeps the guaranteedReply payment type. Buying a guarantee and fulfilling one remain separate operations.
Fan history cannot restore the creator's pending state
History validation clears isGuaranteedReplyPending for a fan. Incoming guaranteed-reply handling also refuses to set it for a fan. The PR leaves isReplyGuaranteed intact, so the fan's required-tip gate still applies.
A no-op redemption no longer discards the creator's reply
In the message-container callback, a successful response with isRedeemed: false now sends the message and completes its queue entry. The base shows the generic error and never sends the reply in that branch. A redeemed reply still clears the pending flag and shows the wallet confirmation.
A completed payment keeps its success outcome
The checkout callback now opens the existing thank-you popup when redemption returns isRedeemed: false. The payment-success handler already sends the socket message before attempting redemption. The new fallback does not send it again. The existing popup returns the user to their origin when it closes.
HTTP errors still use the existing error handler. The new thank-you path applies to a successful redemption response with nothing redeemed.
Regression evidence
I extracted the actual component methods from the reviewed TypeScript, transpiled them, and ran them with assertions. HTTP responses, sockets, modals, and routing were mocked. I also ran the relevant methods from the base commit to verify the before-and-after behaviour.
| Scenario | Base commit | PR head |
|---|---|---|
| Fan tip with a stale pending flag | Payment payload sets fulfillGuaranteedReply: true. | Payload sets the flag to false. Normal paid-tip success skips redemption. |
| Creator reply, successful response, nothing redeemed | Generic error. No socket send. | One socket send and one queue completion. No generic error. |
| Paid tip with an already-set fulfillment flag, nothing redeemed | Checkout shows the generic error after payment. | Checkout shows the thank-you. The socket message sends once. |
The other checks cover all eight combinations of sender role, recipient role, and pending state. They exercise all three payment builders, the paid-message and free-credit dispatch paths, history and incoming pending-state handling, the fan permission gate, successful redemption, and the checkout HTTP-error branch.
The guaranteed-reply purchase check confirms that the fan still buys the correct payment type. A locked permission state still prevents tip checkout.
Checks and limits
| Check | Result |
|---|---|
| TypeScript | tsc -p tsconfig.app.json --noEmit passes. |
| Angular templates | ngc -p tsconfig.app.json --noEmit passes. |
| Main application build | ng build TopFans --configuration=development --prerender=false passes. Browser and server bundles generated, zero prerendered routes. |
| Targeted regression checks | 33 pass against methods extracted from the reviewed head. Three base reproductions confirm the previous failures. |
| Diff whitespace | The reviewed base-to-head diff passes git diff --check. |
| Configured dev build | Cannot start. Its file replacement references the absent environment.dev.ts. The same file is absent from the base. I left environment files unchanged. |
| Build warnings | Two unused LazyVendorCssDirective imports in unrelated components. They do not stop the build. |
| GitHub automation | No check runs or commit statuses listed for this head. No submitted reviews. |
| Live product checks | No signed-in checkout, real charge, wallet settlement, socket delivery acknowledgement, or mobile payment was exercised. |
| Production and tenants | Production build, generated white-label builds, fresh SSR requests, and prerender were not run. The PR changes no tenant configuration or rendering code. |
I used a detached checkout of the reviewed head, the workspace's installed Angular 21.2.23 dependencies, and a 10 GB Node heap. The targeted checks prove frontend branching and callback behaviour. They do not prove the backend's payment or redemption contract.
Follow-up
A no-op creator redemption still leaves the local pending flag set.
The fallback sends the reply but does not clear incomingGuaranteedReplySid or isGuaranteedReplyPending. Later replies can attempt redemption again, and the pending badge can remain. The base already left that state behind. This PR fixes the blocked send, so I would track the stale-state cleanup separately after confirming what the backend means by isRedeemed: false.
After deployment, check a normal fan tip, a paid message with a tip, and a creator's pending guaranteed reply using test accounts. Confirm the thank-you returns to the conversation, the recipient receives one message, and the creator wallet changes only when the backend redeems the guarantee.